gh-96159: Fix significant performance degradation in logging.TimedRotat… (GH-96182) #96182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
dgrisby
changed the title
dgrisby
changed the title
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
…otatingFileHandler due to fix to python#89564 Only check for special files when the rollover time has passed, rather than cheking on every log message.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
vsajip
approved these changes
Aug 23, 2022
vsajip
changed the title
vsajip
added
needs backport to 3.10
|
GH-96195 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2022
…medRotat… (pythonGH-96182) (cherry picked from commit 1499d73) Co-authored-by: Duncan Grisby <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2022
…medRotat… (pythonGH-96182) (cherry picked from commit 1499d73) Co-authored-by: Duncan Grisby <[email protected]>
|
GH-96196 is a backport of this pull request to the 3.11 branch. |
vsajip
pushed a commit
that referenced
this pull request
Aug 23, 2022
…imedRotat… (GH-96182) (GH-96195) Co-authored-by: Duncan Grisby <[email protected]>
vsajip
pushed a commit
that referenced
this pull request
Aug 23, 2022
…imedRotat… (GH-96182) (GH-96196) Co-authored-by: Duncan Grisby <[email protected]>
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix for #96159. The cost of checking for non-regular files is now only incurred when the rollover time is reached, rather than on every single log message.
A similar change could be made to RotatingFileHandler, but does seek() and tell() calls on the file, which are probably bad to do on special files, so I thought it was safer to leave it with the file type check on every call.