gh-96352: Set AttributeError context in _PyObject_GenericGetAttrWithDict #96353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Aug 28, 2022
There was a problem hiding this comment.
Hi, thanks for you contribution! You need to add a news entry, see the failing test details.
Or use https://blurb-it.herokuapp.com/
I also think that adding a test case for this won't hurt.
|
Hi, thanks for the review! Test and news entry added. |
pablogsal
approved these changes
Sep 8, 2022
pablogsal
added
needs backport to 3.10
|
Thanks @philg314 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Thanks for the PR @philg314 🎉 |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 8, 2022
…rWithDict (pythonGH-96353) (cherry picked from commit b9634ac) Co-authored-by: philg314 <[email protected]>
|
GH-96682 is a backport of this pull request to the 3.11 branch. |
bedevere-bot
removed
needs backport to 3.11
|
GH-96683 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 8, 2022
…rWithDict (pythonGH-96353) (cherry picked from commit b9634ac) Co-authored-by: philg314 <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 8, 2022
…ict (GH-96353) (cherry picked from commit b9634ac) Co-authored-by: philg314 <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 8, 2022
…ict (GH-96353) (cherry picked from commit b9634ac) Co-authored-by: philg314 <[email protected]>
|
Thanks for the reviews @sobolevn and @pablogsal and thanks for merging @pablogsal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes AttributeErrors's
nameandobjto be set inobject.__getattribute__.Ping @pablogsal, author of #16856
object.__getattribute__does not setnameandobjofAttributeError#96352