Errors when merging consecutive leading-indented (?) overload statements

[bzoracler]

Bug Report, To Reproduce, & Actual Behaviour

In the following, sys.version_info >= ... can be any other compile-time constant (e.g. those set by always_true / always_false, typing.TYPE_CHECKING, etc.).

It appears that consecutive overload merge candidate blocks cause this issue; adding an additional statement between the blocks (here, # UNCOMMENT_ME_TO_FIX = ...) allow the overloads to resolve properly.

mypy Playground

import sys
import typing as tp

if sys.version_info >= (3, 10):
    @tp.overload
    def a(arg: str, /) -> str: ...
    @tp.overload
    def a(arg: int, /) -> int: ...

def a(arg: str | int, /) -> str | int:
    return arg

# UNCOMMENT_ME_TO_FIX = ...

if sys.version_info >= (3, 9):
    @tp.overload  # main.py:16: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
    def b(arg: str, /) -> str: ...
    @tp.overload
    def b(arg: int, /) -> int: ...

def b(arg: str | int, /) -> str | int:  # main.py:21: error: Name "b" already defined on line 16  [no-redef]
    return arg

Expected Behavior

No issues

Your Environment

• Mypy version used: 1.10.1
• Mypy command-line flags: None
• Mypy configuration options from mypy.ini (and other config files): None
• Python version used: 3.12

[bzoracler]

The problem can be localised in this loop:

mypy/mypy/fastparse.py

Line 606 in 3c9f694

for stmt in stmts:

More specifically, if the current statement terminates a previous series of analysed overloads leading to an OverloadedFuncDef to be saved,

mypy/mypy/fastparse.py

Lines 688 to 691 in 3c9f694

	if len(current_overload) == 1:
	ret.append(current_overload[0])
	elif len(current_overload) > 1:
	ret.append(OverloadedFuncDef(current_overload))

the current statement is not fully re-analysed for the presence of potential overloads. That is, the following doesn't repeat the same analysis at the beginning of the loop for the current statement.

mypy/mypy/fastparse.py

Lines 698 to 719 in 3c9f694

	seen_unconditional_func_def = False
	if isinstance(stmt, Decorator) and not unnamed_function(stmt.name):
	current_overload = [stmt]
	current_overload_name = stmt.name
	elif isinstance(stmt, IfStmt) and if_overload_name is not None:
	current_overload = []
	current_overload_name = if_overload_name
	last_if_stmt = stmt
	last_if_stmt_overload_name = None
	if if_block_with_overload is not None:
	skipped_if_stmts.extend(
	cast(List[IfStmt], if_block_with_overload.body[:-1])
	)
	last_if_overload = cast(
	Union[Decorator, FuncDef, OverloadedFuncDef],
	if_block_with_overload.body[-1],
	)
	last_if_unknown_truth_value = if_unknown_truth_value
	else:
	current_overload = []
	current_overload_name = None
	ret.append(stmt)

A quick hack to force full re-analysis of the current statement solves this particular issue:

                else:
                    current_overload = []
                    current_overload_name = None
+                   if isinstance(stmt, IfStmt):
+                       if_overload_name = self._check_ifstmt_for_overloads(stmt, current_overload_name)
+                       if if_overload_name is not None:
+                           ret.extend(self.fix_function_overloads(stmts[stmts.index(stmt):]))
+                           break
                    ret.append(stmt)