Skip to content

Fix tests when running pypy #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Fix tests when running pypy #84

merged 4 commits into from
Oct 7, 2022

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Oct 7, 2022

Closes: #83

@srittau srittau changed the title Run CI against pypy Fix tests when running pypy Oct 7, 2022
@@ -18,15 +18,15 @@ jobs:
# Python version, because typing sometimes changed between bugfix releases.
# For available versions, see:
# https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
python-version: ["3.7", "3.7.1", "3.8", "3.8.0", "3.9", "3.9.0", "3.10", "3.10.0", "3.11-dev"]
python-version: ["3.7", "3.7.1", "3.8", "3.8.0", "3.9", "3.9.0", "3.10", "3.10.0", "3.11-dev", "pypy3.9"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to also test pypy3.8 and (perhaps) pypy3.7, as all three branches are still being maintained.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's skip the other pypy versions for now to save on those precious CI minutes. (The Python org ran into troubles before IIRC.)

@srittau srittau merged commit 3a54ef1 into python:main Oct 7, 2022
@srittau srittau deleted the ci-pypy branch October 7, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test regression with pypy3.9: test_overload_on_compiled_functions
3 participants