Skip to content

Update Python version requirement for Windows #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Update Python version requirement for Windows #1527

merged 4 commits into from
Dec 13, 2023

Conversation

svekars
Copy link
Collaborator

@svekars svekars commented Dec 12, 2023

No description provided.

@svekars svekars requested a review from malfet December 12, 2023 23:13
Copy link

netlify bot commented Dec 12, 2023

👷 Deploy Preview for pytorch-dot-org-preview processing.

Name Link
🔨 Latest commit b74de08
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/657a212b87ff880008878305

@malfet
Copy link
Contributor

malfet commented Dec 13, 2023

LGTM, though I don't think it fixes the issue, it would be nice to have a note somewhere outlining what is needed (right now it say NOTE: Latest PyTorch requires Python 3.8 or later., which is misleading as Python 3.12 is not supported)

@svekars
Copy link
Collaborator Author

svekars commented Dec 13, 2023

which is misleading as Python 3.12 is not supported)

I can change it but I think @albanD wanted to keep it less specific as my understanding 3.12 will be supported in one of the upcoming releases.

@albanD
Copy link

albanD commented Dec 13, 2023

I think there should be one place that is the full detailed description (with details on 3.8 upcoming demise and 3.12 partial state).
Everywhere else we should be vague enough that it doesn't get stale every couple months (linking back to the singlee source of truth if needed).

@svekars svekars merged commit 89ba69b into site Dec 13, 2023
@svekars svekars deleted the fix-95628 branch December 13, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants