Skip to content

Sync aspects of old site with new site #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Sync aspects of old site with new site #65

merged 1 commit into from
Sep 20, 2018

Conversation

JoelMarcey
Copy link
Contributor

  • Combine _config.ymls for the most part
  • Add docs dir as part of the infra
  • Make /docs not an external URL
  • Use excludes instead of removing files/dirs in Makefile
  • etc.

Tested locally. Also setup Netlify previews as well. Hopefully it works for this PR.

Next up will be automatic CI build into master.

- Combine `_config.yml`s for the most part
- Make /docs not an external URL
- Use excludes instead of removing files/dirs in Makefile
- etc.

Tested locally. Also setup Netlify previews as well. Hopefully it works for this PR.
@facebook-netlify-bot
Copy link

Deploy preview for infallible-bhabha-cf3724 ready!

Built with commit eade19d

https://deploy-preview-65--infallible-bhabha-cf3724.netlify.com

@JoelMarcey
Copy link
Contributor Author

The main review is at the top. The crux of this PR is me adding the docs dir to the branch.

@soumith, et. al. If you are good with this, we will want to have the pytorchbot auto-generating sphinx docs to the site branch instead of master.

Copy link
Contributor

@ericnakagawa ericnakagawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merged _configs look accurate. Thanks for adding licenses back, too.

@JoelMarcey JoelMarcey merged commit 6ff5ffa into pytorch:site Sep 20, 2018
ssnl pushed a commit to ssnl/pytorch.github.io that referenced this pull request Oct 2, 2018
ssnl pushed a commit to ssnl/pytorch.github.io that referenced this pull request Oct 2, 2018
ssnl pushed a commit to ssnl/pytorch.github.io that referenced this pull request Oct 2, 2018
andresruizfacebook pushed a commit that referenced this pull request Sep 21, 2020
* Add anchor to community module under Resources dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants