Fix Redirects and Move PyTorch Versions to Getting Started #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on moving PyTorch versions to a tab in Getting Started, and setting up a redirect from the old page, I noticed that the docs redirect (with `redirect_url` was clashing with the default redirects using `redirect_from` - if you look at the prod site, you will notice that the latter redirects do not work any longer). So, I changed the layout name of the redirect for docs to `docs_redirect.html` and then the others use the default redirect mechanism provided by the redirect plugin
JoelMarcey
requested review from
ericnakagawa,
caabernathy,
brianjo,
brucejlin and
jspisak
|
Deploy preview for infallible-bhabha-cf3724 ready! Built with commit 70b240e https://deploy-preview-83--infallible-bhabha-cf3724.netlify.com |
ssnl
pushed a commit
to ssnl/pytorch.github.io
that referenced
this pull request
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on moving PyTorch versions to a tab in Getting Started, and setting up a redirect from the old page, I noticed that the docs redirect (with
redirect_urlwas clashing with the default redirects usingredirect_from- if you look at the prod site, you will notice that the latter redirects do not work any longer). So, I changed the layout name of the redirect for docs todocs_redirect.htmland then the others use the default redirect mechanism provided by the redirect plugin