Skip to content

Migrate to correct logger interface #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR resolves the annoying deprecation warnings of the logger library:

DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead

See CI logs for those warnings.

Signed-off-by: Emmanuel Ferdman <[email protected]>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@TroyGarden TroyGarden self-requested a review June 20, 2025 17:45
Copy link
Contributor

@TroyGarden TroyGarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the BE work.

@TroyGarden
Copy link
Contributor

@pytorchbot merge

Copy link

pytorch-bot bot commented Jun 20, 2025

Mergebot is not configured for this repository. Please use the merge button provided by GitHub.

@facebook-github-bot
Copy link
Contributor

@TroyGarden has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@TroyGarden TroyGarden closed this Jun 20, 2025
TroyGarden pushed a commit to TroyGarden/torchrec that referenced this pull request Jun 20, 2025
Summary:
## PR Summary
This small PR resolves the annoying deprecation warnings of the `logger` library:
```python
DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
```
See [CI logs](https://github.com/pytorch/torchrec/actions/runs/15201361250/job/42755956905#step:15:5170) for those warnings.


Reviewed By: spmex

Differential Revision: D77035942

Pulled By: TroyGarden
facebook-github-bot pushed a commit that referenced this pull request Jun 21, 2025
Summary:
Pull Request resolved: #3123

## PR Summary
This small PR resolves the annoying deprecation warnings of the `logger` library:
```python
DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
```
See [CI logs](https://github.com/pytorch/torchrec/actions/runs/15201361250/job/42755956905#step:15:5170) for those warnings.

Pull Request resolved: #2996

Reviewed By: spmex

Differential Revision: D77035942

Pulled By: TroyGarden

fbshipit-source-id: 36f4915ddde3bfc2204f95747434a0a55ed911a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants