Add kernel config fragment for custom Linux kernel recipe #1125
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsiddoji
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
rsiddoji
force-pushed
the
master
branch
2 times, most recently
from
dda3068 to
b9b4d22
Compare
|
Github doesn't seem to allow including the commit message in reviews, so:
The commit policy is "Recipe: change", so change it to something like "linux-qcom-next: add support for KERNEL_CONFIG_FRAGMENTS"
That's not your name |
lumag
reviewed
Oct 14, 2025
lumag
reviewed
Oct 14, 2025
rsiddoji
force-pushed
the
master
branch
3 times, most recently
from
6f0f1ba to
c0d7a33
Compare
lumag
requested changes
Oct 15, 2025
| KBUILD_DEFCONFIG ?= "defconfig" | ||
| KBUILD_DEFCONFIG:qcom-armv7a = "qcom_defconfig" | ||
|
|
||
| KERNEL_CONFIG_FRAGMENTS = " ${UNPACKDIR}/configs/qcom.cfg" |
Certain kernel features, require specific kernel configuration options that are not present in the default configuration. Introducing kernel config fragment support to explicitly define required configuration for custom features. Signed-off-by: Ravi Kumar Siddojigari <[email protected]>
ndechesne
reviewed
Oct 15, 2025
| KBUILD_DEFCONFIG ?= "defconfig" | ||
| KBUILD_DEFCONFIG:qcom-armv7a = "qcom_defconfig" | ||
|
|
||
| KERNEL_CONFIG_FRAGMENTS = "${UNPACKDIR}/configs/qcom.cfg" |
There was a problem hiding this comment.
it's not clear how we intend to use this new variable. especially because it's initialized without =?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kernel config fragment support for custom Linux kernel recipe.