Skip to content

[Rails 6.1 CI] Use PostgreSQL 1.2.3 #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Feb 10, 2022

The Rails 6.1 Windows CI is failing because the PostgreSQL v1.3.1 gem cannot be installed on the Windows CI image. See https://ci.appveyor.com/project/wpolicarpo/activerecord-sqlserver-adapter/builds/42526232/job/uqyayud4m8mssojy

The Windows CI last passed when PostgreSQL v1.2.3 gem was used. See https://ci.appveyor.com/project/wpolicarpo/activerecord-sqlserver-adapter/builds/41990100/job/f776f13o08f7pyo1

This PR will force the CI to use v1.2.3 of the pg gem. This will allow the Linux CI and Windows CI tests to pass.

Note: This issue does not affect main since no Windows CI builds currently pass on main. It may affect 6-0-stable and so might need to be back-ported there.

@aidanharan aidanharan changed the title [Rails 6.1] For Windows CI use PostgreSQL 1.2.x [Rails 6.1] On Windows CI use PostgreSQL 1.2.x Feb 14, 2022
@aidanharan aidanharan force-pushed the ci-appveyor-pg-version branch from cbd8294 to 44b77b3 Compare February 14, 2022 13:47
@aidanharan aidanharan marked this pull request as ready for review February 14, 2022 17:17
@aidanharan aidanharan changed the title [Rails 6.1] On Windows CI use PostgreSQL 1.2.x [Rails 6.1] On Windows CI use PostgreSQL 1.2.3 Feb 14, 2022
@aidanharan aidanharan force-pushed the ci-appveyor-pg-version branch from 48d4a65 to 66bbca6 Compare February 14, 2022 17:19
@aidanharan aidanharan changed the title [Rails 6.1] On Windows CI use PostgreSQL 1.2.3 [Rails 6.1 CI] Use PostgreSQL 1.2.3 Feb 14, 2022
@aidanharan
Copy link
Contributor Author

aidanharan commented Feb 23, 2022

@wpolicarpo Could a new release for Rails 6.1 be created? Issue #999 was initially created in relation to Rails 6.1. The fix has been released for Rails 7.0 but not 6.1. The fix for #999 was merged into the 6-1-stable branch in PR #1006

There is an issue with the 6-1-stable Windows CI failing but this would be fixed by #1007

@aidanharan aidanharan merged commit 42d27f2 into rails-sqlserver:6-1-stable Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant