Skip to content

Fix deprecation warning to reference Rails 7 #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Mar 28, 2022

Fix deprecation message in test that references Rails 6.2 instead of Rails 7.0.

See https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/5626810774?check_suite_focus=true

Failure:
RelationTest#test_reorder_with_first_coerced [/activerecord-sqlserver-adapter/test/cases/coerced_tests.rb:1201]:
No deprecation warning matched (?-mix:`\.reorder\(nil\)`\ with\ `\.first`\ \/\ `\.first!`\ no\ longer\ takes\ non\-deterministic\ result\ in\ Rails\ 6\.2\.\ To\ continue\ taking\ non\-deterministic\ result,\ use\ `\.take`\ \/\ `\.take!`\ instead\.): DEPRECATION WARNING: `.reorder(nil)` with `.first` / `.first!` no longer takes non-deterministic result in Rails 7.0. To continue taking non-deterministic result, use `.take` / `.take!` instead. (called from block (2 levels) in test_reorder_with_first_coerced at /activerecord-sqlserver-adapter/test/cases/coerced_tests.rb:1202)

rails test activerecord-sqlserver-adapter/test/cases/coerced_tests.rb:1194

@aidanharan aidanharan marked this pull request as ready for review March 28, 2022 12:48
@aidanharan aidanharan merged commit 379ea9b into rails-sqlserver:6-1-stable Mar 28, 2022
@aidanharan aidanharan deleted the fix-deprecation-warning branch March 28, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant