Skip to content

Remove QueryMethods patch that is no longer required #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Jul 14, 2021

Remove the QueryMethods patch that is no longer required since the main branch is now for Rails 6.1+ development.

See https://github.com/rails/rails/blob/914caca2d31bd753f47f9168f2a375921d9e91cc/activerecord/lib/active_record/relation/query_methods.rb#L1322 for the Rails method that matches the patch being removed.

@aidanharan aidanharan force-pushed the query_methods_cleanup branch from 5b2f814 to f04ea9a Compare July 14, 2021 14:50
@aidanharan aidanharan marked this pull request as ready for review July 15, 2021 10:47
Removed require

No longer required for Rails 6.1+

Removed require
@aidanharan aidanharan force-pushed the query_methods_cleanup branch from 181543d to 4792244 Compare July 26, 2021 08:42
@wpolicarpo wpolicarpo merged commit ace9588 into rails-sqlserver:main Jul 29, 2021
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
Removed require

No longer required for Rails 6.1+

Removed require

Co-authored-by: Aidan Haran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants