Use ruby command "gem list" for foreman existence test

[elalemanyo]

Hi,
I know this does not solve any current problem, but maybe would be better to use the command gem list to check for foreman. This command gives a better output (boolean) and appropriate exit code.

Thanks

Related with /pull/91

[elalemanyo]

@MrJoy I know this is something you fixed a few days ago, but maybe this is a good way to improve it, what do you think?
Or is your way better?
Thanks

[MrJoy]

Seems perfectly reasonable to me.

[kevynlebouille]

Hi @elalemanyo ,

Your version output true or false in the console.

Here is my proposal

if ! gem list foreman -i --silent; then

[elalemanyo]

Hi @elalemanyo ,

Your version output true or false in the console.

Here is my proposal

if ! gem list foreman -i --silent; then

@kevynlebouille I love your proposal, Thanks!

[elalemanyo]

@MrJoy do you think we can merge this? 😁

[MrJoy]

I'm not a maintainer, so it's not really for me to say. I can say that the fix works perfectly fine for my use-case and I fully support merging it.