Swallow bundler exceptions when running tests

[robin850]

Hello,

This is just a tiny patch that avoids useless output when testing stuff related to Bundler in the railties test suite like this since the Gemfile points to a non-released version.

Have a nice day.

[senny]

With bundler 1.6 and ruby 2.0.0 I don't see any warnings when running app_generator_test.rb:

railties :: (master) » ruby -Itest test/generators/app_generator_test.rb
Run options: --seed 16436

# Running:

................................................................

Finished in 16.952444s, 3.7753 runs/s, 24.6572 assertions/s.

64 runs, 418 assertions, 0 failures, 0 errors, 0 skips

I'll check with Ruby 2.1.1

[JuanitoFatas]

I just ran with Ruby 2.1.1 & bundler 1.6.2:

$ ruby -v
ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin10.0]
$ bundle -v
Bundler version 1.6.2

Run on the rails master branch:

[railties] (master) $ ruby -Itest test/generators/app_generator_test.rb
Run options: --seed 37816

# Running:

........................................................../Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/resolver.rb:352:in `resolve': Could not find gem 'rails (= 4.2.0.alpha) ruby' in the gems available on this machine. (Bundler::GemNotFound)
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/resolver.rb:165:in `start'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/resolver.rb:129:in `resolve'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:203:in `resolve'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:133:in `specs'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:178:in `specs_for'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:167:in `requested_specs'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/environment.rb:18:in `requested_specs'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/runtime.rb:13:in `setup'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler.rb:120:in `setup'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/setup.rb:17:in `<top (required)>'
    from /Users/Mac/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /Users/Mac/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
./Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/resolver.rb:352:in `resolve': Could not find gem 'rails (= 4.2.0.alpha) ruby' in the gems available on this machine. (Bundler::GemNotFound)
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/resolver.rb:165:in `start'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/resolver.rb:129:in `resolve'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:203:in `resolve'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:133:in `specs'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:178:in `specs_for'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/definition.rb:167:in `requested_specs'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/environment.rb:18:in `requested_specs'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/runtime.rb:13:in `setup'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler.rb:120:in `setup'
    from /Users/Mac/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.2/lib/bundler/setup.rb:17:in `<top (required)>'
    from /Users/Mac/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /Users/Mac/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
.....

Finished in 38.975418s, 1.6421 runs/s, 10.7247 assertions/s.

64 runs, 418 assertions, 0 failures, 0 errors, 0 skips

Then run @robin850 branch.

[railties] (pr/14881) $ ruby -Itest test/generators/app_generator_test.rb
Run options: --seed 40648

# Running:

................................................................

Finished in 28.957375s, 2.2101 runs/s, 14.4350 assertions/s.

64 runs, 418 assertions, 0 failures, 0 errors, 0 skips

[senny]

@JuanitoFatas are you on OS-X or Linux?

[senny]

I didn't have enough time to debug it all the way down. However it looks like it's related to Bundler.with_friendly_errors.

@robin850 do you have Bundler.with_friendly_errors { Bundler::CLI.start(ARGV, :debug => true) } in your bundle binary?

@hone does this with_friendly_errors ring any bells? Could it be different per platform?

[robin850]

@senny: Yep I have, here's the content of my bundle bin.

[JuanitoFatas]

@senny I'm on OS X. I found the error message is from the resolver.rb. And content of my bundle bin. Hope it helps.

[robin850]

@senny : Any chance to get this in please ? If you want an SSH access on my computer, you can send me an e-mail.

[senny]

@robin850 thanks for reminding me. I'll see wether I can debug this in the near future.

[robin850]

@senny: No problem, thanks for merging! :-)