Add Action Text to guides [ci skip] #34878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanvlviv
force-pushed
the
action_text-guides-docs
branch
from
c022efc to
22da0f9
Compare
- Move some actiontext/README.md content to Action Text Overview guide - I added WIP label to that guide since we definitely want to complement it. - Add Action Text to Major Features of Rails 6.0 Similar approach was used in rails#34812
bogdanvlviv
force-pushed
the
action_text-guides-docs
branch
from
22da0f9 to
0fb6c90
Compare
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 13, 2019
…skip] In rails#34709 we updated the guide, but `actioncable/README.md` is still outdated. Instead of fixing content in the file. I suggest not duplicate the info that is already in the guide and instead remove the info from the file and just add a message: "You can read more about Action Cable in the [Action Cable Overview](https://edgeguides.rubyonrails.org/action_cable_overview.html) guide." The same approach is being used for Action Mailbox and Action Text, see rails#34812 and rails#34878.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 21, 2019
We added "Action Mailbox Basics", "Action Text Overview" guides(rails#34812, rails#34878) I think it makes to mention about it in the changelog file. (Similar to 7200ec9) Note that entries retain original author since I just moved content from readme files to the guides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar approach was used in #34812
/cc @georgeclaghorn