Adds default trix content attachmment partial path #35485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
javan
added a commit
that referenced
this pull request
Dec 3, 2019
A regression introduced in 764803e caused blobs to appear as HTML content attachments instead of file / image attachments when editing rich text content. This change restores the original intended behavior. References: #35485, basecamp/trix#706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActionText automatically renders out the
to_partial_pathfor attachables when rendering rich text. However, when you edit the rich text field, attachments don't render the same partial path for Trix making it seem like your attachments disappeared.This makes it so attachables use the same partial path for rendering to html and to Trix. This way they'll render consistently in both cases.
cc @georgeclaghorn