Use Public API for React-Router instead of Private Context #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* IndexLinkContainer: * Wrapped `withRouter` as default export, * Now exports original component separately * LinkContainer: * Wrapped `withRouter` as default export, * Now exports original component separately * `contextTypes` validation has been removed * `propTypes` now expects `history` object, as it is expected to be wrapped `withRouter` * `this.context.router.history` references replaced with `this.props.history` * Tests updated to deal with wrapped component vs real component references * git ignore updates
* Made `history` propType required * Added propTypes: `location`, `match`, `staticContext`, since `withRouter` will provide them * Updated `render()` to strip props (`location`, `match`, `staticContext`) from children
|
This is great, thanks! |
|
For curiosity, when can we expect a new release with this change? |
I agree. LinkContainer is broken for anyone upgrading to react-router 5.x, so breadcrumbs stop working without hacky solutions that lead to nested anchors and validateDOMnesting warnings. |
|
+1 to a release. Also feeling the pain as I'm working with react-router v5. @v12 any timeline? |
|
A workaround is available here #250 |
|
@v12 are you |
|
released in v0.25.0 |
|
@taion thank you! |
|
@v12 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: https://github.com/ReactTraining/react-router/releases/tag/v4.4.0-beta.0
Since react-router-bootstrap uses the forbidden contextTypes, this PR addresses that.
In short, LinkContainer is now exported by default, wrapped by
withRouter. This exposeshistoryand such directly as a property on LinkContainer.Additionally, the original unwrapped LinkContainer class is exported, if desired.
Summary of changes:
withRouteras default export,withRouteras default export,contextTypesvalidation has been removedpropTypesnow expectshistoryobject (required), as it is expected to be wrappedwithRouterlocation,match,staticContext, sincewithRouterwill provide themthis.context.router.historyreferences replaced withthis.props.historyrender()to strip props (location,match,staticContext) from childrenFixes #237