Allow touchable to be stylable #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Based on issue: #216
There is a problem on how react-native-web handles the transformation when it comes to flex, absolute and relative positioning. Basically Text container (TouchableOpacity in our case) is not expanding to full size.
Thus I opened API for TouchableOpacity styles. This will allow users to change actual padding of the clickable area. No backwards compat introduced, very small code change but this will grant devs more power when it comes to styling.
Since library uses different components for IOS and android:
Test Plan
I dont see any tests in the library so here is my video:
Screen.Recording.2021-06-07.at.17.22.20.mov
If you would like to test it yourself, just point your dependency to my branch: