Skip to content

Update visual examples and added code examples #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Update visual examples and added code examples #1214

merged 11 commits into from
Mar 7, 2024

Conversation

Piotrfj
Copy link
Contributor

@Piotrfj Piotrfj commented Feb 23, 2023

This PR will update old visual examples and add them in missing spots

@Piotrfj Piotrfj requested a review from satya164 February 23, 2023 15:39
@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit 3a44635
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/65e0f2645cc69b0008a4ddc8
😎 Deploy Preview https://deploy-preview-1214--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this so far! 🎉

Some remarks:

  • Could you rename the PR to better describe what changes were really made?
  • Could you merge changes from the current main (eg. git merge origin/main) and add your changes to v7 version of the docs?

Thanks!

@satya164 satya164 force-pushed the main branch 2 times, most recently from a2a5d9e to fcb5e31 Compare February 28, 2024 16:34
# Conflicts:
#	versioned_docs/version-6.x/headers.md
#	versioned_docs/version-6.x/navigating.md
#	versioned_docs/version-7.x/drawer-based-navigation.md
#	versioned_docs/version-7.x/header-buttons.md
#	versioned_docs/version-7.x/headers.md
#	versioned_docs/version-7.x/modal.md
#	versioned_docs/version-7.x/multiple-drawers.md
#	versioned_docs/version-7.x/navigating.md
#	versioned_docs/version-7.x/navigation-lifecycle.md
#	versioned_docs/version-7.x/preventing-going-back.md
#	versioned_docs/version-7.x/status-bar.md
#	versioned_docs/version-7.x/tab-based-navigation.md
@groot007 groot007 changed the title Update of the documentation Update visual examples and added code examples Feb 29, 2024
@satya164 satya164 merged commit ea353f0 into main Mar 7, 2024
@satya164 satya164 deleted the update branch March 7, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants