-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update visual examples and added code examples #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on this so far! 🎉
Some remarks:
- Could you rename the PR to better describe what changes were really made?
- Could you merge changes from the current main (eg.
git merge origin/main
) and add your changes to v7 version of the docs?
Thanks!
…ithub.io into update # Conflicts: # versioned_docs/version-6.x/modal.md
….github.io into update
a2a5d9e
to
fcb5e31
Compare
# Conflicts: # versioned_docs/version-6.x/headers.md # versioned_docs/version-6.x/navigating.md # versioned_docs/version-7.x/drawer-based-navigation.md # versioned_docs/version-7.x/header-buttons.md # versioned_docs/version-7.x/headers.md # versioned_docs/version-7.x/modal.md # versioned_docs/version-7.x/multiple-drawers.md # versioned_docs/version-7.x/navigating.md # versioned_docs/version-7.x/navigation-lifecycle.md # versioned_docs/version-7.x/preventing-going-back.md # versioned_docs/version-7.x/status-bar.md # versioned_docs/version-7.x/tab-based-navigation.md
satya164
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update old visual examples and add them in missing spots