Skip to content

Improve DNS response parser to limit recursion for compressed labels #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

clue
Copy link
Member

@clue clue commented Sep 24, 2020

This changeset improves the DNS response parser to limit recursion for compressed labels. This prevents a possible infinite recursion in malformed DNS response messages. The maximum recursion depth is limited to 127 labels, matching the maximum host name length of 255 permitted as per DNS specs.

Builds on top of #115
Refs #114

This prevents a possible infinite recursion in malformed DNS response
messages. The maximum recursion depth is limited to 127 labels, matching
the maximum host name length of 255 permitted as per DNS specs.
@jsor jsor merged commit 31b5641 into reactphp:master Sep 27, 2020
@clue clue deleted the compression-recurse branch September 28, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants