Fix minimum phpunit version and allow v5 #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was actually reverted in 4.8.21. In other words: This actually works perfectly fine currently and installs 4.8.35 on PHP 7 (at the time of writing this). That being said, I agree that it makes perfect sense to support PHPUnit 5 as well 👍 |
clue
approved these changes
Feb 11, 2017
WyriHaximus
approved these changes
Feb 11, 2017
jsor
approved these changes
Feb 11, 2017
clue
requested changes
Feb 11, 2017
composer.json
Outdated
| @@ -16,6 +16,6 @@ | |||
| } | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "~4.8" | |||
| "phpunit/phpunit": "^4.8.10|^5.0" | |||
There was a problem hiding this comment.
Arguably, fixing the lowest version and supporting PHPUnit 5 could be two separate PRs, but I'll leave this up to you 👍
|
@clue was a bit lazy and didn't split. Both phpunit 4 and 5 tests are passing now. |
👍
|
Once this is merged, #114 should pass, too. |
This was referenced Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #111 and #114
phpunit ^5.0 is required since as of 4.8.20 php 7.0 is not supported (see https://github.com/sebastianbergmann/phpunit/blob/4.8.32/ChangeLog-4.8.md)
Welcome to version hell :/