-
Notifications
You must be signed in to change notification settings - Fork 30
Add strongly typed options to Intl modules #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strongly typed options to Intl modules #194
Conversation
46e3457
to
8298258
Compare
Good stuff @glennsl ! Ready to merge? |
As far as I'm aware, yes. I wouldn't count out having made some mistakes though, so a thorough review wouldn't be a bad idea. |
@glennsl Thanks! There is also #65 (a more encompassing Intl bindings PR). One difference I see is that #65 distinguishes between Also see the discussion there starting with #65 (comment) (polymorphic variants vs. regular variants). |
@@ -1,17 +1,27 @@ | |||
type t | |||
|
|||
type options = { | |||
usage?: [#sort | #search], | |||
localeMathcer?: [#lookup | #"best fit"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo (occurs several times)
Ah, I've missed that. That's so much better! This is mostly just a lazy copy of my own bindings with some additions to flesh it out. I'll just close this and comment over there then. |
No description provided.