-
-
Notifications
You must be signed in to change notification settings - Fork 250
Adding a sub nav to the docs section to reduce the amount of content in the main nav #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jderochervlk
wants to merge
14
commits into
master
Choose a base branch
from
vlk-doc-nav
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+129
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying rescript-lang-org with
|
Latest commit: |
9bc434e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://aaf4cff4.rescript-lang.pages.dev |
Branch Preview URL: | https://vlk-doc-nav.rescript-lang.pages.dev |
As mentioned on Discord: this is almost done but the mobile "sidebar" overlay now misses the close button. |
fhammerschmidt
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also let us move things out of the doc sidebar and create subnav links for: Getting Started, Guides, Api, Syntax Lookup, and anything else we want to split up to reduce the amount of things in the sidebar. This should also help increase visibility into different sections and provide a better path for newcomers.
An example of what I am attempting:

Desktop
Tablet
Mobile
Wide desktop