Fix for alerts in Chrome Browsers #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves all the alert keyword in to a own _AlertKeywords class. This did make it easier to fix the bug with WebDriverWait class.
This commit moves all the alert keyword in to a own _AlertKeywords class. This did make it easier to fix the bug with WebDriverWait class.
|
The build failed, but it's an unrelated issue. I queued it up again. Also, 👍 for the separation of alerts into its own file. |
|
Looks good to me. Feel free to merge pending @pekkaklarck's feedback. |
aaltat
added a commit
that referenced
this pull request
Oct 3, 2015
Fix for alerts in Chrome Browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves all the alert keyword in to a own _AlertKeywords
class. This did make it easier to fix the bug with WebDriverWait
class.