Print fix #626
Print fix #626
Conversation
|
I am on holiday, so will take a look after the holidays are over. |
|
Nice holiday. This is just small part of #479 (python 3) |
|
Hi, Let me call to attention that we have several PRs for Python 3 compatibility, mine is #564. |
|
Yes. I check your combined PR and this change is small bite. There are - I agree - plenty of issues to check and fix to make same code base running both python2 / python 3. I just tested in the first place those changes not violating python 2 code base and make code closer to python 3. Python 3 working tests need also more work to get work back to agile path. I also run those tests with Windows / Python 3.5 and they failed but you cant eat whole cake. So I just run those 2to3.py tests which did not break python 2 codebase. |
|
Thanks for the PR. I've promised to take care of S2L Py3 support and will review related PRs as soon as I got time. Current main blockers are finishing our move to a new home and getting new S2L release (w/p Py3 support) out with @aaltat. Realistically that means I can concentrate on this task at the end of this month. |
|
The 1.8.0 is out and during the release process we changed few things. The changes caused a conflict(s) and by looking the pull request I can see at leas one problem. The |
| @@ -28,7 +28,7 @@ def _run_on_failure_decorator(method, *args, **kwargs): | |||
| class KeywordGroupMetaClass(type): | |||
| def __new__(cls, clsname, bases, dict): | |||
| if decorator: | |||
| for name, method in dict.items(): | |||
| for name, method in list(dict.items()): | |||
* 2to3.py runned for print & except * 2to3.py runned for except * 2to3.py -f dict
* 2to3.py runned for print & except * 2to3.py runned for except * 2to3.py -f dict
Some 2to3 partial changes to be done for future python 3 work.
These seems to go ok without extra modifications