Prevent Rails 3.2.22.1 on Ruby 1.8.7 #1540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
referenced
this pull request
Jan 27, 2016
This is because the security release of `3.2.22.1` was not correctly tested against 1.8.7 which means that our build will not pass against this ruby. /cc @pixeltrix.
JonRowe
force-pushed
the
fix_187_rails_3_2_22_1
branch
4 times, most recently
from
d7feb80 to
1931382
Compare
JonRowe
force-pushed
the
fix_187_rails_3_2_22_1
branch
from
1931382 to
5d69354
Compare
|
@samphippen ready for review |
|
@JonRowe this LGTM, do you think it wants a changelog entry? |
JonRowe
added a commit
that referenced
this pull request
Feb 2, 2016
Prevent Rails 3.2.22.1 on Ruby 1.8.7
|
Hmm, I'm on the fence it's mostly internal but it will prevent 1.8.7 from installing that version of Rails so maybe? |
|
it's marginally user facing, so adding a changelog entry can't hurt imo. |
|
Done |
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming this works it'll fix our builds elsewhere and improves upon @samphippen's quick travis fix :)