UTF-8 encoding fix.

[krogebry]

I was having an issue where the AD server was sending back bad utf-8 code ( \x82 I believe was the code value ). I'm currently using this fix in a production scenario. I would love to get some feedback on if this is a valid fix.

[Ajedi32]

I believe I'm having this same issue in my application:

C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/net-ldap-0.3.1/lib/net/ber/core_ext/string.rb:23:in `encode': "\x82" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/net-ldap-0.3.1/lib/net/ber/core_ext/string.rb:23:in `raw_utf8_encoded'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/net-ldap-0.3.1/lib/net/ber/core_ext/string.rb:15:in `to_ber'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/net-ldap-0.3.1/lib/net/ldap.rb:1396:in `block in search'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/net-ldap-0.3.1/lib/net/ldap.rb:1367:in `loop'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/net-ldap-0.3.1/lib/net/ldap.rb:1367:in `search'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/net-ldap-0.3.1/lib/net/ldap.rb:637:in `search'
        from ldap_test.rb:13:in `<main>'

I'll try your fix and let you know if it works for me.

Update: It worked, great fix! (+1) I'm still pretty new to Ruby so I can't say for sure whether or not what you did is the best way to fix the problem, but your commit definitely does the job. This bug was basically making net-ldap unusable for me, so I think it would be a good idea to pull this commit ASAP.

[psy-q]

I second that, we have the same issues with Microsoft products and would be grateful for a fix.

[miks]

This solves also our problems with Microsoft products. Please merge this, so we can use this without manual patching.

[DougHall]

I finally gave up waiting for this bug fix and just installed the net-ldap-1 gem, instead. Works like a charm. How about keeping the official branch up-to-date please.

[RoryO]

Merged all the back pull requests and I'll push out a 0.4 tonight

Rory O'Connell
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Tuesday, August 28, 2012 at 12:08 PM, Doug Hall wrote:

Yea, I finally gave up waiting for this bug fix and just installed the net-ldap-1 gem, instead. Works like a charm. How about keeping the official branch up-to-date please.

—
Reply to this email directly or view it on GitHub (#44 (comment)).

[virgilm]

Uh, no 0.4? This was 20 days ago...

[adimitri]

@RoryO - I was bit by this bug too. Was wondering if you could push out the 0.4 soon? Thanks!

[PhilT]

Would like to see a new release for this too. Cheers.

[normelton]

Agreed here!

[schaary]

A new release would be fine. The utf-8 bug is very annoying.

[cthulhu666]

Not sure if it's the best way to fix the problem, but at least it makes net-ldap usable for me.

[darksoul42]

Just stumbled upon this bug while setting up Redmine... New release would be highly appreciated ;(

[alik78]

I got that code update manually into my local gem lib. So now instead of of error I get nil returned :
Not quite what I was going for... I am trying to list all groups in AD

filter = Net::LDAP::Filter.eq("objectclass", "group")
groups = ldap.search(:base => base, :filter => filter)
=> nil
Any thoughts on what I could be doing wrong here?
Thanks!

[ghost]

+1 for a new release. This is really annoying.

[kevincodux]

Why is this still not pulled?

[ghost]

The issue itself should be fixed in the current master branch (at least I didn't experience any issues with it) and you can reference it via your Gemfile like this:

gem "net-ldap", :git => "git://github.com/ruby-ldap/ruby-net-ldap.git", :branch => "master"

But it would be nice if the gem on rubygems.org would have been updated. Sadly this project seems a bit abandoned.

[kevincodux]

Weird; if it was merged with master, Github should say so. Thanks anyway.

[ghost]

As you can see on https://github.com/ruby-ldap/ruby-net-ldap/commits/master/lib/net/ber/core_ext/string.rb there already was some code merging which should have fixed this issue.

So normally this pull request here could be closed. The issue really is that the gem hasn't been updated and people are thus coming to this repo to complain about code issues for whom fixes already could and should have been "shipped".

[chuckbjones]

It looks like this pull request is a duplicate of #41, which was pulled and is now closed. Not exactly the same code change, but solves the same problem.

[erniebrodeur]

[tschreier]

I am out of the office until 11.02.2013.Meine E-Mails werden nicht gelesen oder weitergeleitet.Gerne werde ich nach meiner Rückkehr Ihre Nachricht beantworten.In dringenden Fällen erreichen Sie uns unter [email protected] oder Tel. 0049 5031 9408-0.Vielen herzlichen Dank.Note: This is an automated response to your message "Re: [ruby-net-ldap] UTF-8 encoding fix. (#44)" sent on 06.02.2013 20:24:10. This is the only notification you will receive while this person is away.
i.Q. Gesellschaft für individuelle Qualitätssicherung mbH
Kirschenkamp 3
D-30926 Seelze
Geschäftsführer: Thomas Schreier
Amtsgericht Hannover HRB 110570
Umsatzsteuer-ID: DE173555521

[djscruggs]

This is still an issue two years later. Fortunately I was able to fix it using the gemfile change suggested by sebi.