Catch Encoding::ConverterNotFoundError #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some binary format on Active Directory can raise "Encoding::ConverterNotFoundError". Signed-off-by: Jason Franklin <[email protected]>
RoryO
pushed a commit
that referenced
this pull request
Jul 22, 2013
Catch Encoding::ConverterNotFoundError
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
…d_error Catch Encoding::ConverterNotFoundError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled across this error, while performing and LDAP search on a Microsoft Active Directory 2008 RC2 (AD).
This specific installation had been migrated form why back when (NT times).
In this case some binary data was being returned, which caused a "Encoding::ConverterNotFoundError" error to be thrown. Catching this error and returning self instead of trying to encode to "UTF-8" provides a workaround for the problem.
Unfortunately the AD in question doesn't belong to me, so I can't give you more specifics on the data returned.
This is the reason why I was unable to provide a test case for this fix.
Signed-off-by: Jason Franklin [email protected]