N22: Nestadia #644
Merged
N22: Nestadia #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zer0x64
force-pushed
the
source
branch
2 times, most recently
from
281aa40 to
7bd6484
Compare
AngelOnFira
reviewed
Jun 2, 2021
AngelOnFira
reviewed
Jun 2, 2021
AngelOnFira
reviewed
Jun 2, 2021
AngelOnFira
reviewed
Jun 2, 2021
AngelOnFira
reviewed
Jun 2, 2021
AngelOnFira
reviewed
Jun 2, 2021
AngelOnFira
reviewed
Jun 2, 2021
AngelOnFira
requested changes
Jun 2, 2021
Member
AngelOnFira
left a comment
AngelOnFira
left a comment
There was a problem hiding this comment.
Great writeup 😄 a few changes needed, but otherwise this should be good 💯
Contributor
Author
|
Sorry if the english is kinda broken at some places, it's my second language 🙃 I've fixed your comments and pushed them! |
Member
|
Awesome, looks good 😄 There are a few linting issues, but I've submitted a PR to your fork with fixes for them. |
Contributor
Author
|
I just merged your PR! |
AngelOnFira
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Part of #640