-
Notifications
You must be signed in to change notification settings - Fork 71
Description
Proposal
Sometimes diagnostics wish to guide users to using newer Rust features, but suggesting them may cause a crate's MSRV to increase. Clippy has machinery to record where lints are only relevant to certain Rust versions. It would be useful to be able to use this for Rust's own lints - however, this requires knowing the current crate's MSRV, which is not currently exposed to rustc (except via CARGO_PKG_RUST_VERSION).
Introducing a MSRV flag to rustc allows Cargo (and any other tools) to pass this information to rustc with a more standard API (which Clippy may additionally benefit from, as it currently parses the environment variable).
Motivating example: rust-lang/rust#149870
Process
The main points of the Major Change Process are as follows:
- File an issue describing the proposal.
- A compiler team member who is knowledgeable in the area can second by writing
@rustbot secondor kickoff a team FCP with@rfcbot fcp $RESOLUTION.- Refer to Proposals, Approvals and Stabilization docs for when a second is sufficient, or when a full team FCP is required.
- Once an MCP is seconded, the Final Comment Period begins.
- Final Comment Period lasts for 10 days after all outstanding concerns are solved.
- Outstanding concerns will block the Final Comment Period from finishing. Once all concerns are resolved, the 10 day countdown is restarted.
- If no concerns are raised after 10 days since the resolution of the last outstanding concern, the MCP is considered approved.
You can read more about Major Change Proposals on forge.