Skip to content

feat: enhance signature help to display generic parameters for callables and default values for generic args #19596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

feat: enhance signature help to display generic parameters for callables and default values for generic args #19596

merged 1 commit into from
Apr 16, 2025

Conversation

roife
Copy link
Member

@roife roife commented Apr 15, 2025 •
edited by rustbot
Loading

fix #12729, #19373.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2025
Veykril
Veykril approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a related note, it would be nice if we'd show monomorphized signatures, that is, drop the generic params that are inferred from context. Sounds difficult to do (and we still dont do this properly for hovers even).

crates/ide/src/signature_help.rs
}
"#,
expect![[r#"
enum Option<T>::Some({unknown})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this said enum Option<T>::Some(T), we should open a follow up issue for that

@Veykril Veykril added this pull request to the merge queue Apr 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2025
@Veykril
Merge pull request #19596 from roife/sig-help-info
09fe999 
feat: enhance signature help to display generic parameters for callables and default values for generic args
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
@Veykril Veykril added this pull request to the merge queue Apr 16, 2025
@Veykril Veykril removed this pull request from the merge queue due to a manual request Apr 16, 2025
@Veykril Veykril added this pull request to the merge queue Apr 16, 2025
Merged via the queue into rust-lang:master with commit d5a3d14 Apr 16, 2025
14 checks passed
@roife roife mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generics signature help should include type parameter defaults
3 participants
@roife @Veykril @rustbot