feat: Allow unsetting env vars in server.extraEnv config
#19634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
jyn514
reviewed
Apr 20, 2025
Veykril
force-pushed
the
push-mnpmxxrprymo
branch
2 times, most recently
from
a3b364f to
7918812
Compare
|
@BenjaminBrienen the typescript CI seems to fail now on the |
Veykril
force-pushed
the
push-mnpmxxrprymo
branch
from
7918812 to
46cd1ce
Compare
It just wants you to run prettier. |
|
Well no, it is formatted. |
|
Oh, nevermind. It only reports the files that have formatting erorrs on them, but not the formatting issues themselves ... |
Veykril
force-pushed
the
push-mnpmxxrprymo
branch
from
46cd1ce to
05b374a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19627