Skip to content

Fix question_mark suggesting when type is behind Deref include parentheses #14655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Fix question_mark suggesting when type is behind Deref include parentheses #14655

merged 1 commit into from
Apr 22, 2025

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Apr 20, 2025 •
edited by rustbot
Loading

Close #14615

changelog: [question_mark]: when type is behind Deref include parentheses

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 20, 2025
Jarcho
Jarcho requested changes Apr 21, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 21, 2025
@alex-semenyuk alex-semenyuk force-pushed the parentheses_question_mark branch from 5214689 to 7a4d523 Compare April 21, 2025 17:26
@alex-semenyuk alex-semenyuk requested a review from Jarcho April 21, 2025 17:36
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 21, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 21, 2025
@alex-semenyuk alex-semenyuk force-pushed the parentheses_question_mark branch from 928a4b7 to 7a4d523 Compare April 21, 2025 17:45
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) has-merge-commits PR has merge commits, merge with caution. labels Apr 21, 2025
Jarcho
Jarcho approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Apr 22, 2025
Merged via the queue into rust-lang:master with commit aeb6ac9 Apr 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

question_mark suggesting incorrect code when type is behind Deref (missing parentheses)
3 participants
@alex-semenyuk @rustbot @Jarcho