Skip to content

Conversation

@tgross35
Copy link
Contributor

@tgross35 tgross35 commented Feb 4, 2025

This includes rust-lang/compiler-builtins#752 which is required for LLVM 20.

r? @ghost

This includes [1] which is required for LLVM 20.

[1]: rust-lang/compiler-builtins#752
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@tgross35
Copy link
Contributor Author

tgross35 commented Feb 4, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 4, 2025

📌 Commit 90fee92 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Feb 5, 2025

(Edited [1] to instead just use the link because I was reading the PR description and was very confused 😆)

@tgross35
Copy link
Contributor Author

tgross35 commented Feb 5, 2025

Yeah, numeric links look better in commit messages than the UI :)

@bors bors merged commit f30ce21 into rust-lang:master Feb 6, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 6, 2025
@tgross35 tgross35 mentioned this pull request Feb 6, 2025
7 tasks
@tgross35 tgross35 deleted the update-builtins branch February 6, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants