bootstrap: add rustc-dev install target

[Nadrieril]

I'm entirely new to bootstrap but there seemed to be no easy way to construct a sysroot with tools and librustc_driver.so. ./x install is the command for that but as far as I can tell it doesn't include the rustc-dev files. This is my attempt at adding that.

./x install rustc-dev now does what you expect (at least on my machine™). If I'm understanding correctly this also means that ./x install will now include rustc-dev files if build.tools contains "rustc-dev".

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Kobzol]

a sysroot with tools and librustc_driver.so

You mean a sysroot that has compiler rlibs available? rustc-dev is a very special component useful only for tools that leverage rustc_private. Otherwise a sysroot with tools and librustc_driver.so should be easily buildable with build.extended = true and ./x dist.

[anforowicz]

a sysroot with tools and librustc_driver.so

You mean a sysroot that has compiler rlibs available? rustc-dev is a very special component useful only for tools that leverage rustc_private. Otherwise a sysroot with tools and librustc_driver.so should be easily buildable with build.extended = true and ./x dist.

IIUC dist will only build a tarball (right?). Chromium depends on install to actually put things into a directory that is then packaged and distributed using a custom (GCS) system. So I think this PR would still be useful to Chromium. See https://crbug.com/460482110 for more details and background.

The job aarch64-gnu-llvm-20-2 failed!

IIUC we just need to update the golden/expected snapshots - i.e. add [dist] rustc 1 <x86_64-unknown-linux-gnu> -> rustc-dev 2 <x86_64-unknown-linux-gnu> right below

rust/src/bootstrap/src/core/builder/tests.rs

Line 2914 in b33119f

[dist] rustc <x86_64-unknown-linux-gnu>

[jieyouxu]

I'm a bit hesistant on adding ./x install rustc-dev, since like Jakub said, that dist component is intended for rustc_private tools, so its not clear to me what ./x install rustc-dev is supposed to mean. I'll pull this into a bootstrap zulip thread a bit later.

EDIT: oh, I guess it's #general > Help building and **installing** `rustc_driver` et al
EDIT 2: discussing in #t-infra/bootstrap > ./x install rustc-dev?.

[anforowicz]

The job aarch64-gnu-llvm-20-2 failed!

IIUC we just need to update the golden/expected snapshots - i.e. add [dist] rustc 1 <x86_64-unknown-linux-gnu> -> rustc-dev 2 <x86_64-unknown-linux-gnu> right below

rust/src/bootstrap/src/core/builder/tests.rs

Line 2914 in b33119f

[dist] rustc <x86_64-unknown-linux-gnu>

@Nadrieril, could you try running the following commands to update the test expectations?

$ cd src/bootstrap
$ cargo insta test
$ cargo insta review # only a single diff needs explicit acceptance/approval

(h/t @Kobzol - thanks for sharing these commands).

---

I can confirm that after the following steps:

• Patching in this PR into my local Rust build,
• Editing config.toml to include rustc-dev and rust-std
• Running ./x.py install

I can now successfully build Crubit with:

• tools/crates/run_cargo.py -Z unstable-options -C ~/src/github/crubit clean
• tools/crates/run_cargo.py -Z unstable-options -C ~/src/github/crubit build --verbose --bin cc_bindings_from_rs --release

So this PR is definitely helping in my scenario.

[jieyouxu]

I'm still iffy on this one, so I'm going to roll another bootstrap reviewer.

@rustbot reroll

[Kobzol]

r? kobzol

I now understand the use-case, and given that we already provide install steps for a bunch of other steps, I don't see why we shouldn't also offer this. rustc-dev is being used by people outside of bootstrap today, and we can't do much about that :D

[Kobzol]

Thanks!

@bors r+

[bors]

📌 Commit a96d486 has been approved by Kobzol

It is now in the queue for this repository.