Skip to content

Conversation

@lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 4, 2020

Improves one of the more frequent ICE

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2020
@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

r=me with perf results green

r? @Mark-Simulacrum

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Sep 4, 2020

⌛ Trying commit cdd5d60 with merge e5a91a3def8846a0363012f36c4e394cc78e24d0...

@bors
Copy link
Collaborator

bors commented Sep 4, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: e5a91a3def8846a0363012f36c4e394cc78e24d0 (e5a91a3def8846a0363012f36c4e394cc78e24d0)

@rust-timer
Copy link
Collaborator

Queued e5a91a3def8846a0363012f36c4e394cc78e24d0 with parent 4ffb5c5, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (e5a91a3def8846a0363012f36c4e394cc78e24d0): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 4, 2020

📌 Commit cdd5d60 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2020
@bors
Copy link
Collaborator

bors commented Sep 4, 2020

⌛ Testing commit cdd5d60 with merge 42d896a...

@bors
Copy link
Collaborator

bors commented Sep 4, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 42d896a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2020
@bors bors merged commit 42d896a into rust-lang:master Sep 4, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 4, 2020
@lcnr lcnr deleted the map-track-caller branch September 5, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants