const fn wherever possible #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
commented
Nov 2, 2022
| } | ||
|
|
||
| /// Split this error into its inner status and error data | ||
| #[allow(clippy::missing_const_for_fn)] |
There was a problem hiding this comment.
clippy mistakenly thinks this can be const
|
Looks like a few of these can't be const yet with our current msrv |
phip1611
force-pushed
the
const-fncs-2
branch
from
b3ad057 to
427ae3b
Compare
I updated the PR. MSRV bump should no longer be required. |
nicholasbishop
force-pushed
the
const-fncs-2
branch
from
427ae3b to
0086a1d
Compare
nicholasbishop
force-pushed
the
const-fncs-2
branch
from
0086a1d to
878b56c
Compare
nicholasbishop
approved these changes
Nov 16, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #545. It adds
const fneverywhere possible.We need to keep in mind that future refactorings might need to drop the
const. This is considered fine as we do not require things to beconst. In our case, it mainly helps to know if there will be side effects or not.Checklist