Skip to content

Conversation

@som-snytt
Copy link
Contributor

@scala-jenkins scala-jenkins added this to the 2.13.17 milestone May 15, 2025
@som-snytt som-snytt changed the title Use List.fill instead of range Use List.fill instead of range [ci: last-only] May 20, 2025
@som-snytt som-snytt force-pushed the tweak/fix-range-usage branch from 3106171 to bdce213 Compare May 20, 2025 07:11
@lrytz
Copy link
Member

lrytz commented May 20, 2025

hmm, do we have a new unstable test? :-/ it was added recently in #11024

!!  1 - presentation/dollar-completion            [output differs]
% diff /home/runner/work/scala/scala/test/files/presentation/dollar-completion.check /home/runner/work/scala/scala/test/files/presentation/dollar-completion-presentation.log
@@ -3,22 +3,14 @@ reload: Completions.scala
 askScopeCompletion at Completions.scala(5,2)
 ================================================================================
 [response] askScopeCompletion at (5,2)
-retrieved 16 members
+retrieved 8 members
 abstract trait T extends AnyRef
 case class C1 extends Product with Serializable
 class C2 extends AnyRef
 def <init>(x: Int): test.C1
-def canEqual(x$1: Any): Boolean
 def copy(x: Int): test.C1
-def productArity: Int
-def productElement(x$1: Int): Any
 object C1
-override def equals(x$1: Any): Boolean
-override def hashCode(): Int
-override def productElementName(x$1: Int): String
-override def productIterator: Iterator[Any]
 override def productPrefix: String
-override def toString(): String
 private[this] val x: Int
 ================================================================================

@som-snytt
Copy link
Contributor Author

hmm, indeed. I don't remember what my second thoughts were on #10867 to fix something about PC tests.

@lrytz lrytz merged commit 3f09bff into scala:2.13.x May 21, 2025
3 checks passed
@som-snytt som-snytt deleted the tweak/fix-range-usage branch May 21, 2025 07:09
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label May 28, 2025
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request Sep 24, 2025
…sage

Use List.fill instead of range [ci: last-only]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants