Fix and future-proof the CI release scripts #21810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build directly in publish_release
…builds ensure correct pattern is used
hamzaremmal
approved these changes
Oct 19, 2024
WojciechMazur
pushed a commit
that referenced
this pull request
Oct 20, 2024
<img width="1032" alt="Screenshot 2024-10-20 at 07 14 49" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786">https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786"> [positive](https://github.com/WojciechMazur/dotty/actions/runs/11416876799/job/31768568868) test in #21810 also uses `bash` instead of `sh` Closes #21815
WojciechMazur
added a commit
to scala/scala3-lts
that referenced
this pull request
Dec 5, 2024
- Forward-ports changes to `publish_release` CI job from `release-3.6.1` branch. * Fix building SDK archives, don't use `build-sdk-packages` job that produced artifacts in SNAPSHOT version * Fix typos introduced in template (forward port from `release-3.6.0`) - Detect and check version used to publish artifacts: * For release builds ensure that `version` is always matching tag used to trigger CI job * For nightly builds ensure that `version` is following the expected pattern [Cherry-picked 34f1c54][modified]
WojciechMazur
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Dec 5, 2024
<img width="1032" alt="Screenshot 2024-10-20 at 07 14 49" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786">https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786"> [positive](https://github.com/WojciechMazur/dotty/actions/runs/11416876799/job/31768568868) test in scala#21810 also uses `bash` instead of `sh` Closes scala#21815 [Cherry-picked 022b1ff]
WojciechMazur
added a commit
to scala/scala3-lts
that referenced
this pull request
Dec 5, 2024
- Forward-ports changes to `publish_release` CI job from `release-3.6.1` branch. * Fix building SDK archives, don't use `build-sdk-packages` job that produced artifacts in SNAPSHOT version * Fix typos introduced in template (forward port from `release-3.6.0`) - Detect and check version used to publish artifacts: * For release builds ensure that `version` is always matching tag used to trigger CI job * For nightly builds ensure that `version` is following the expected pattern [Cherry-picked 34f1c54][modified]
WojciechMazur
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Dec 5, 2024
<img width="1032" alt="Screenshot 2024-10-20 at 07 14 49" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786">https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786"> [positive](https://github.com/WojciechMazur/dotty/actions/runs/11416876799/job/31768568868) test in scala#21810 also uses `bash` instead of `sh` Closes scala#21815 [Cherry-picked 022b1ff]
WojciechMazur
added a commit
that referenced
this pull request
Dec 9, 2024
- Forward-ports changes to `publish_release` CI job from `release-3.6.1` branch. * Fix building SDK archives, don't use `build-sdk-packages` job that produced artifacts in SNAPSHOT version * Fix typos introduced in template (forward port from `release-3.6.0`) - Detect and check version used to publish artifacts: * For release builds ensure that `version` is always matching tag used to trigger CI job * For nightly builds ensure that `version` is following the expected pattern [Cherry-picked 34f1c54][modified]
WojciechMazur
pushed a commit
that referenced
this pull request
Dec 9, 2024
<img width="1032" alt="Screenshot 2024-10-20 at 07 14 49" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786">https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786"> [positive](https://github.com/WojciechMazur/dotty/actions/runs/11416876799/job/31768568868) test in #21810 also uses `bash` instead of `sh` Closes #21815 [Cherry-picked 022b1ff]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish_releaseCI job fromrelease-3.6.1branch.build-sdk-packagesjob that produced artifacts in SNAPSHOT versionrelease-3.6.0)versionis always matching tag used to trigger CI jobversionis following the expected pattern