Improve use of boolean defaults #23564
Merged
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Jul 26, 2025
A couple of cases where recursing with default booleans was especially confusing. Spellcheck would like to change booleans to beanpoles. I know the project hates so-called style PRs. But if I see something morally wrong, I cannot but act upon it. I must confirm that inlined helper such as `jsig1` allows `tailrec`. Maybe it's enough to annotate jsig? Edit: I see goto 0 only. With tailrec, it complains about the RHS of the helper `inline def jsig1`, which is spurious.
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Jul 26, 2025
A couple of cases where recursing with default booleans was especially confusing. Spellcheck would like to change booleans to beanpoles. I know the project hates so-called style PRs. But if I see something morally wrong, I cannot but act upon it. I must confirm that inlined helper such as `jsig1` allows `tailrec`. Maybe it's enough to annotate jsig? Edit: I see goto 0 only. With tailrec, it complains about the RHS of the helper `inline def jsig1`, which is spurious. [Cherry-picked 3770ee8][modified]
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Jul 28, 2025
A couple of cases where recursing with default booleans was especially confusing. Spellcheck would like to change booleans to beanpoles. I know the project hates so-called style PRs. But if I see something morally wrong, I cannot but act upon it. I must confirm that inlined helper such as `jsig1` allows `tailrec`. Maybe it's enough to annotate jsig? Edit: I see goto 0 only. With tailrec, it complains about the RHS of the helper `inline def jsig1`, which is spurious.
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Jul 28, 2025
A couple of cases where recursing with default booleans was especially confusing. Spellcheck would like to change booleans to beanpoles. I know the project hates so-called style PRs. But if I see something morally wrong, I cannot but act upon it. I must confirm that inlined helper such as `jsig1` allows `tailrec`. Maybe it's enough to annotate jsig? Edit: I see goto 0 only. With tailrec, it complains about the RHS of the helper `inline def jsig1`, which is spurious. [Cherry-picked 3770ee8][modified]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of cases where recursing with default booleans was especially confusing.
Spellcheck would like to change booleans to beanpoles.
I know the project hates so-called style PRs.
But if I see something morally wrong, I cannot but act upon it.
I must confirm that inlined helper such as
jsig1allowstailrec. Maybe it's enough to annotate jsig? Edit: I see goto 0 only. With tailrec, it complains about the RHS of the helperinline def jsig1, which is spurious.