[MRG] Removing 'random_state = 0' while intializing OneClassSVM #10241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing 'random_state = 0' while intializing OneClassSVM.
FarahSaeed
changed the title
Few changes for fixing pep8 errors.
agramfort
approved these changes
Dec 2, 2017
FarahSaeed
changed the title
|
LGTM |
|
Thanks @FarahSaeed |
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…it-learn#10241) and some PEP8 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Reference Issue: #10158
Hi.. Regarding issue #10158, one requirement is related to catching deprecation warnings of random_state in SVC tests.
I've found the following test where the relevant deprecation warnings are raising.
scikit-learn/sklearn/svm/tests/test_sparse.py
Line 264 in 57bcd07
In this PR, the above test is edited to remove 'random_state = 0' while initializing OneClassSVM. Also \examples and \doc are checked to have no use of random_state with OneClassSVM.