Skip to content

Conversation

@TomDLT
Copy link
Member

@TomDLT TomDLT commented Apr 6, 2019

Follow up #13468 with an automatic generation of authors and emeritus tables.

  • Emeritus developer list is now generated automatically.
  • It also adds the dates of first and last pull-request/issue on GitHub, which is a not so bad proxy of activity. This is probably the most sensitive question.
  • It also changes the order to be relative to these dates.
    Specifically:
(int(profile["first_year"]), -int(profile["last_year"]), last_name)

rendered version
rendered version

@jnothman
Copy link
Member

jnothman commented Apr 6, 2019

i'm not sure that get_dates corresponds to the years we would consider someone to be an active core developer. But I certainly like how this looks

@NicolasHug
Copy link
Member

Yeah, for example with myself it says I've been a coredev since 2017 while it's actually been less than a week ^^

It'd be nice also to replace <start_date> -- 2019 with <start_date> -- present

@rth
Copy link
Member

rth commented Jul 12, 2019

It's nice to automate this, but at the same time not having correct dates is not ideal. Maybe removing the dates would make it less controversial?

@TomDLT
Copy link
Member Author

TomDLT commented Jul 12, 2019

I removed the dates.
rendered version

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomDLT !

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new name in the emeritus list (Brian Holt)? What's happening? @TomDLT

@amueller
Copy link
Member

Looks like I missed Brian Holt before, he should be on the list.

@qinhanmin2014 qinhanmin2014 merged commit cad1de2 into scikit-learn:master Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants