Skip to content

Conversation

@thomasjpfan
Copy link
Member

Reference Issues/PRs

Partial address #18345

What does this implement/fix? Explain your changes.

Updates the donation link on the main page.

@TomDLT TomDLT changed the title DOC Updates donatation link on website DOC Updates donation link on website Sep 4, 2020
@thomasjpfan
Copy link
Member Author

Updated link to https://numfocus.org/donate-to-scikit-learn

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial address #18345

Why does this only partially address #18345 ?

@thomasjpfan
Copy link
Member Author

Why does this only partially address #18345 ?

This PR does not add the sponsor button to GitHub. (I preferred to keep this PR smaller, because I feel the sponsorship button may require some discussion)

@TomDLT
Copy link
Member

TomDLT commented Sep 9, 2020

Sounds good, let's merge and discuss further the GitHub button.

@TomDLT TomDLT merged commit fd1ff73 into scikit-learn:master Sep 9, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants