Fixing issue 2560 : Imputer bug with median and dense input #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2560 |
|
@agramfort : I think this is good to go in. Can you review it? |
|
can you add a test? |
|
@agramfort : I have added a test. Please review it. |
There was a problem hiding this comment.
use assert_equal from nose
grep assert_equal in sklearn
otherwise looks great
|
@agramfort : Done. |
|
Thanks for taking care of this! +1 as well as soon as @agramfort comment above is fixed. |
|
@glouppe : Seems like you missed my commit by a few seconds :-) I have also filed numpy/numpy#4012 in numpy about the inconsistent behaviour of |
agramfort
added a commit
that referenced
this pull request
Nov 6, 2013
Fixing issue 2560 : Imputer bug with median and dense input
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.