Skip to content

Conversation

@wjiayis
Copy link
Contributor

@wjiayis wjiayis commented Sep 30, 2024

Reference Issues/PRs

#26927

What does this implement/fix? Explain your changes.

This PR adds a link to the plot_svm_tie_breaking.py example in the docstring of SVC and NuSVC.

Any other comments?

@github-actions
Copy link

github-actions bot commented Sep 30, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: ffdc3f8. Link to the linter CI: here

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

cc: @adrinjalali

@wjiayis wjiayis requested a review from adrinjalali October 15, 2024 12:21
@glemaitre glemaitre self-requested a review October 17, 2024 19:46
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wjiayis

@glemaitre glemaitre requested review from adrinjalali and removed request for adrinjalali October 17, 2024 19:48
@glemaitre glemaitre enabled auto-merge (squash) October 17, 2024 19:48
@glemaitre
Copy link
Member

We will need @adrinjalali to approve for the auto-merge to work :)

@glemaitre glemaitre merged commit c7c05d6 into scikit-learn:main Oct 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants