[MRG] English language changed to IsolationTree docs #5594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narrative documentation, doc strings and example updates for IsolationForest
glouppe
changed the title
|
Yes thanks it looks good. |
agramfort
added a commit
that referenced
this pull request
Oct 26, 2015
[MRG] English language changed to IsolationTree docs
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsolationTreeslooks very nice! I was reading the documentation and example to get a feel for them and think the following small changes to the language would improve the docs.There is one more point on
ensemble/iforest.py:176+where I don't understand what the doc string is trying to tell me. Looking at the code itself I get L206 but 208 confuses me. Maybe together we can improve the doc string. In particular the "why" of doing this.@ngoix could you check that the language change does not change the meaning?
The second commit changes the URL mentioned in
doc/README, is it Ok to sneak it in here?