'[MRG]' issue #6535 #6542
'[MRG]' issue #6535 #6542
Conversation
added link to sclera.metrics.make_scorer
|
Thanks @ohld. We appreciate new contributors to the package. Can you compile the docs into html, and test it? Run |
|
Should I send the screenshot? |
|
Please do, yes =] |
|
|
|
Hmm, the indentation level is bothering me. If you look at the documentation for SelectKBest, you'll see that the indentation style is different. |
| See Also | ||
| --------- | ||
| :func:`sklearn.metrics.make_scorer`: | ||
| Make a scorer from a performance metric or loss function. |
There was a problem hiding this comment.
I'm looking at the comment style here. Can you try removing the space before the right-most colon?
There was a problem hiding this comment.
Is there any space? I don't understand.
There was a problem hiding this comment.
Seems like you fixed the error. Thanks!
There was a problem hiding this comment.
Check out the syntax for the numpy docstring standard: in the see also section, the "func" syntax is not used.
There was a problem hiding this comment.
I just took syntax from this code @GaelVaroquaux.
There was a problem hiding this comment.
Interesting reference. Thanks for adding it, @ohld
|
By the way, check please this silly pull request #6543 |
|
So I do all steps mentioned in #6544 with the same code changes and the result is So the problem was not in my code but in OS and it's behavior. |
|
+1 for merge |
|
@hlin117 so what about merging? |
|
Thanks for your contribution! Merging :) |
4 participants
#6535
Issue was about just to add a link from cross_val_score wiki page to sklearn.metrics.make_scorer, because it worth being there.
This is my first contribution. I will appreciate every comment.