[WIP] Proposed C parameter clarifications in RBF SVM parameter example
#8957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
May 29, 2017
vene
reviewed
Jun 6, 2017
examples/svm/plot_rbf_parameters.py
Outdated
| against maximization of the decision function's margin. For larger values of | ||
| ``C``, a smaller margin will be accepted if the decision function is better at | ||
| classifying all training points correctly. A lower ``C`` will encourage a larger | ||
| margin, and a more simple decision function, even if that decision function |
There was a problem hiding this comment.
"and a more simple decision function [...]." -> "therefore a simpler decision function, at the cost of training accuracy?
Without the "therefore" it might seem that "simplicity" is a different measure that we're not defining, (and frankly would be tricky to define.) This way we just suggest that the two are related.
The other part of my proposed change is simply reducing verbosity :)
use phrasing suggested by @vene.
|
Thanks Andreas! Ive been meaning to get to that rewording for some time 😅
…On Wed, May 23, 2018, 12:51 PM Andreas Mueller ***@***.***> wrote:
Merged #8957 <#8957>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8957 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB-gYEhzxTClo5CgD8K6OKFuLg43wQp3ks5t1b3XgaJpZM4NpoLD>
.
|
|
Only a year or so ;) |
qinhanmin2014
added a commit
that referenced
this pull request
May 24, 2018
I think there's concensus on not to introduce new flake8 errors cc @amueller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #7955
What does this implement/fix? Explain your changes.
This proposal changes the description of the RBF SVM parameters example to not include confusing wording relating to
Climiting the number of support vectors in the wrong direction, and instead focuses on a more interpretable description that relates to practical usage.Any other comments?
I need some feedback that this description is intuitive and is clear to understand, and actually an improvement in the right direction :)
Specifically: