Add learning from incidents post for Sidekiq #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulpathak3
added a commit
to nakulpathak3/scribd.github.io
that referenced
this pull request
Dec 21, 2020
Ran generate-tags as I realized in scribd#79 that we haven't in a while it seems. These currently 404 in production (https://tech.scribd.com/tag/kubernetes/).
rtyler
approved these changes
Dec 21, 2020
nakulpathak3
force-pushed
the
nakulp/sidekiq-incident-learnings
branch
from
46a73fd to
ddb8531
Compare
cktaylor
reviewed
Dec 21, 2020
cktaylor
reviewed
Dec 21, 2020
nakulpathak3
commented
Dec 21, 2020
|
@cktaylor @nakulpathak3 Let me know when you're both on the same page for this post and I can ship it 😄 |
cktaylor
approved these changes
Dec 21, 2020
We're good to go @rtyler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI I ran(Fixed in #80)./generate-tagsas per the contributing doc and it generated a lot more than just thesidekiqtag but all those would 404 without it so I think we should keep them.