Skip to content

PRINCE: Fix deprecated construct in po-parse script #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PRINCE: Fix deprecated construct in po-parse script #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c2422
PRINCE: Fix syntax error in po-parse.pl
Botje Aug 14, 2025
5c0e0d3
PRINCE: gen-translations.sh expects an input filename now
Botje Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion engines/prince/gen-translations.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
#! /bin/bash

cp -v ../../../scummvm/devtools/create_prince/en.po .
set -e

translations_dir="$1"
if [ -z "$translations_dir" ] || [ ! -d "$translations_dir" ]; then
echo "Usage: $0 <path-to-scummvm-game-translations>" >&2
echo "Download or clone from https://github.com/scummvm/game-translations/tree/prince-and-the-coward" >&2
exit 1
fi

cp -v "$translations_dir"/en.po .
perl po-parse.pl en en.po
../../scummvm-tools-cli --tool pack_prince .
cp -v prince_translation.dat ../../../scummvm/dists/engine-data/
10 changes: 5 additions & 5 deletions engines/prince/po-parse.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ ($)

print OUT "invtxt.dat\nitemNr. name - exam text\n";

for my $n (sort {$a<=>$b} keys $data1{'invtxt.txt'}) {
for my $n (sort {$a<=>$b} keys %{$data1{'invtxt.txt'}}) {
print OUT "$n. $data1{'invtxt.txt'}{$n}\n";
}

Expand All @@ -150,7 +150,7 @@ ($)

print OUT "variatxt.dat\nstringId. string\n";

for my $n (sort {$a<=>$b} keys $data1{'variatxt.txt'}) {
for my $n (sort {$a<=>$b} keys %{$data1{'variatxt.txt'}}) {
print OUT "$n. $data1{'variatxt.txt'}{$n}\n";
}

Expand All @@ -166,7 +166,7 @@ ($)

my $pn = 0;

for my $n (sort {$a<=>$b} keys $data1{'mob.lst'}) {
for my $n (sort {$a<=>$b} keys %{$data1{'mob.lst'}}) {
my $p1 = int($n / 1000);

if ($p1 != $pn) {
Expand Down Expand Up @@ -197,7 +197,7 @@ ($)
for my $f (sort grep /^dialog/, keys %data1) {
$f =~ /dialog(\d+)/;
my $dialog = $1;
my $hasDialog = !!grep { $_ > 100 } keys $data1{$f};
my $hasDialog = !!grep { $_ > 100 } keys %{$data1{$f}};

if ($hasDialog) {
print OUT "\@DIALOGBOX_LINES:\n";
Expand All @@ -208,7 +208,7 @@ ($)
my $seenDialogBox = 0;
my $prevBox = -1;

for my $n (sort {$a<=>$b} keys $data1{$f}) {
for my $n (sort {$a<=>$b} keys %{$data1{$f}}) {
my $s = $data1{$f}{$n};
if ($n < 100) {
while ($s =~ /^P#/) {
Expand Down